Responsive page using media queries

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Hunter! 👋

  Congratulations on finishing this challenge! 🎉

  I thought that two things can be done better.

  • First, I recommend using either flexbox or grid to center the card instead of using absolute positioning. Also, I suggest not limiting the height of the body element. So, I recommend making the body element as flexbox or grid container and using min-height instead of height to allow it to grow if needed (on mobile landscape view).
  • Secondly, avoid using !important. In this case, you don't need it so if you are using it there's something that needs to be fixed in your CSS.

  Hope this helps.

  Marked as helpful

  0

  ---

  

  Hunter•80

  @huntoorPosted over 2 years ago

  @vanzasetia Thank you

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @huntoor No problem! 😉

  0
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="container"> instead of <div class="container">.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  0

  ---

  

  Hunter•80

  @huntoorPosted over 2 years ago

  @Samadeen Thank you

  0