Design comparison
Solution retrospective
All comments and are appreciated
Community feedback
- @saogijiPosted over 2 years ago
@MaxiTeddy its an amazing work, you should also check out the report and try to fix the accessibility issues, it is important for everyone to be able to access your webpage without troubles. Nice work.
Marked as helpful0 - @vanzasetiaPosted over 2 years ago
Hi, Ogiji Max! 👋
Congratulations on completing this challenge! 🎉
Some suggestions from me.
- Use CSS to uppercase the text. The uppercased word in the HTML might be spelled by the screen reader (spelled letter by letter).
- Always specify the
type
of thebutton
. In this case, set the type of them astype="button"
. It will prevent the button from behaving unexpectedly (like submitting). - Create a custom
:focus-visible
styling for any interactive elements (button
, links,input
,textarea
). This will let people who use a keyboard to navigate the site know where they are currently on the page.
Hope this helps. Happy coding! 😁
Marked as helpful0@vanzasetiaPosted over 2 years ago@MaxiTeddy
I recommend removing the tags that aren't relevant to the project. In this case, the project is built with HTML and CSS. So, remove the #astro, #axios, #bulma, and #chai tags.
Ultimately, you can leave the tag empty if the project doesn't have any specific focus or tools.
Also, don't forget to fix all the issues that have been reported. 🙂
You can learn more about each issue and find the solution to solve each issue by clicking the "Learn more" link. If you have any questions about each issue, feel free to ask me. I would be happy to help you. 😊
0@MaxiTeddyPosted over 2 years ago@vanzasetia Thanks very much, I would try to fix all the stuffs, and use your opinion
0 - @KhantMin200Posted over 2 years ago
Nice work! My opinion is you should use CSS property 'cursor: pointer' on 'learn more' button to show that we can click that button.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord