Design comparison
SolutionDesign
Solution retrospective
Should I change the way I coded the image color overlay? What else should I change to make the page look better? All feedback is appreciated, thank you in advance.
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @Taro2211 👋🏻
I have some quick tips for the project.
- First, let's bring the item to the center of the screen, here's how to do it:
body { background-color: hsl(233, 47%, 7%); font-family: sans-serif, Arial; display: flex; flex-direction: column; justify-content: center; align-items: center; min-height: 100vh; }
you already did the most part of it, all I had to do is to add
min-height: 100vh;
to give the body ability to grow if needed, so it did 🙃- Instead of giving fixed
width
s try to work with relative units, like percentage,
main { width: 100%; }
so I changed it to
100%
to let the image grow more, so it doesn't look distorted and shrunk.- Lastly, for
<p>
tag in.content
instead ofpadding-bottom: 30px;
replace it withmargin-bottom: 50px;
. This will give it some white space and make it to look closer to the original design.
I hope this was helpful 👨🏻💻 other than that, you did a great job for your second project, nicely done. Cheers 👾
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord