Responsive Page Using HTML CSS AND JAVASCRIPT

Community feedback

• 

  Aman Singh Bhogal•1,010

  @asbhogalPosted over 1 year ago

  Hi Mohammad,

  So far the styling looks like a good match to the mockup.

  I've taken a look at your code and have added some suggestions below:

  • Your picture shouldn't be used in CSS, it should be within a <picture></picture> element with the relevant src paths and links to the mobile and desktop versions which appear respective to the viewport width. I've attached a link from MDN about how to do this. The pictures should then show up. Link
  • Also, locally host your Google Fonts for privacy and performance reasons. Here's a good video explaining why and how to do this. Link
  • Another point - use Vercel or Netlify to deploy your projects, not GitHub pages. The first two are much more robust platforms designed to handle client-side, front-end applications with better performance, caching and building.
  • In terms of your JS, the logic looks fine, however to ensure code maintainability, it's good practice to have separated functions isolated with a specific purpose which are called within others, instead of having a single function which handles multiple logic. You can refactor your code to have the regex performed in a separate function called validEmailCheck() for example, which is passed the value as a parameter and returns a boolean value based on a .test() which is then used in the conditional check in the next function.

  Hope this helps!

  Marked as helpful

  1

  ---

  

  Mohammad Saif•100

  @Thebeast01Posted over 1 year ago

  @asbhogal Thank you so much sir, this is really helpful for me , thanks for pointing out my mistakes and informing me. I am delightful that you added links for me to study and learn. Thank you so much for giving your time and helping me to grow. I'll make sure that I do better next time and do not repeat these mistakes.

  0