Responsive page using HTML and CSS ---Grid and Flexbox

Community feedback

• 

  Walter Sono•660

  @waltersonoPosted over 3 years ago

  Nice work Leskim

  It looks alike

  As a suggestion i would say:

  • Add a transition to the button, so that the hover effect feels smooth

  • Use the correct tags to the correct elements: use <header>, for the header, the <main> for the main and <footer> for the footer

    • Using the correct tags helps search engine classify your website better, helps people with disabilities have access to your content in the right way

  • Use some CSS naming convention

  • Your code should work but also be maintainable

  • Try BEM, is not perfect but its a good

  • Instead of targeting you headings (h2, h3, h4, etc) by html structure, target them by class

    • This has to do with maintainable code, in this case if you ever change the order of you html, the h2 will no longer have the styles applied to them

  That is it!

  Keep the good work

  0

  ---

  

  Lesley Kimutai•565

  @LeskimPosted over 3 years ago

  @waltersono Thanks Walter, your input helps a lot ...I'll implement the correct tags issue and button transition. I'll learn about the BEM part and the maintainability issue...If you have a link to a resource that will aid and simplify my work, I'll be grateful

  0

  

  Walter Sono•660

  @waltersonoPosted over 3 years ago

  @Leskim Checkout Jonas.io course on Mastering CSS its the most complete course on CSS i've ever seen.

  0

  

  Lesley Kimutai•565

  @LeskimPosted over 3 years ago

  @waltersono Ok

  0