Design comparison
Solution retrospective
This was my second time using Grid, so please gimme some feedbacks
Community feedback
- @HassiaiPosted over 1 year ago
the html must have <h1> to fix the accessibility issues. Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
Give the body a background-color.
To center .estura on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
USING FLEXBOX: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
USING GRID: body{ min-height: 100vh; display: grid; place-items: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @Finney06Posted over 1 year ago
Hello there ๐. Good job on completing the challenge !
Here is a suggestion regarding your code that may be of interest to you.
HTML ๐ท๏ธ:
To clear the Accessibility report:
- Starting with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that your document has a clear and consistent hierarchy.
I hope you find it helpful!๐ Above all, the solution you submitted is ๐. ๐Happy coding!
Marked as helpful0 - Starting with
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord