Responsive page using Flexbox, Grid and %

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Nícolas, congrats on completing the challenge!

  I had a look at your solution and I have a few suggestions for you:

  • for the internal spaces of the text__container class of the elements try to use the padding instead of the margin
  • To center the cards on the page try using Flexbox, it can help you better: give the flexbox and height properties to the body and remove all margin from the .container class.
  • Note: Flexbox aligns to the size of the parent container. You can use the 100vh measurement for the height.
  • Attribute alt not allowed on element source
  • Element img is missing required attribute src

  Overall you did well :) keep it up

  Hope this help ;)

  Marked as helpful

  1

  ---

  

  Nícolas Gabriel•140

  @Nick-GabePosted almost 3 years ago

  @denielden Thanks for the help, Daniel! I'll apply your recommendations :)

  1
• 

  Gildas MBEUTEU•20

  @mgsepiolPosted almost 3 years ago

  For the classes names, my approach is always to choose something close to what i am styling. Something that can quickly make me thing of it !

  Marked as helpful

  1

  ---

  

  Gildas MBEUTEU•20

  @mgsepiolPosted almost 3 years ago

  @mgsepiol First you group all the elements by their nature or what they have in common. Next you can think of class names based on those groups

  Marked as helpful

  0

  

  Nícolas Gabriel•140

  @Nick-GabePosted almost 3 years ago

  @mgsepiol Interesting, I will keep that in mind next time. Thank you :)

  0