@correlucas
Posted
👾Hello @skozmi, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.
Check the link for the official documentation for <picture> in W3 SCHOOLS:
https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture>
<source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
<img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>
👨💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1
✌️ I hope this helps you and happy coding!
Marked as helpful
@skozmi
Posted
Hello @correlucas, thank you for the helpful suggestion. I didn't know for picture tag. Also, html and css validators (https://codebeautify.org/cssvalidate or https://validator.w3.org/) should also be used before uploading the project for validation. i have warnings - css validator: -The universal selector (*) is known to be slow. -The box-sizing properties isn't supported in IE6 and IE7. -Assure properties are in alphabetical order -For older browsers that don't support RGBA, HSL, or HSLA, provide a fallback color. -Headings should be defined only once. -Selectors should not contain IDs.
Best regards and thank you again!
