Skip to content
Submitted over 2 years ago

Responsive page using flexbox

Icekid35ā€¢260
@Icekid35
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Community feedback

  • Shashree Samuelā€¢9,260
    @shashreesamuelPosted over 2 years ago

    Hey Icekid35, good job completing this challenge. Keep up the good work

    Your solution doesn't match the design in terms of the following

    • Your card needs to be a bit wider

    • The background color of the card should match the color specified in style-guide.md file

    • The dice needs some padding using padding.

    In terms of accessibility issues

    • Buttons must have text, you can fix this by specifying the aria-label attribute

    • html tag must have the lang attribute like this <html lang="en">

    • Wrap all your content between <main> tags to get rid of the rest of accessibility issues

    In terms of the validation errors then once you fix the accessibility issues your validation errors should disappear

    I hope this helps Cheers

    Happy coding šŸ‘

    Marked as helpful
    0
    Icekid35ā€¢260
    @Icekid35Posted over 2 years ago

    @TheCoderGuru thanks changed

    0
  • Muh Suryadi Triputra Rahmanā€¢400
    @msuryaditriputraRPosted over 2 years ago

    Hi Icekid35 šŸ‘‹

    You have amazing work.. Good job šŸ™Œ then adding a copy feature and adorable icons are an impressive idea. Nice! šŸ¤˜

    However, i have some suggestions for u

    • You should wrap the advice title with h1 to fix your accessibility issue do you have. Page should contain a level-one heading
    • Add some padding in the copy element and add border-radius too.
    • For Divider, actually you can use the image assets but it's no big deal. Nice try to build your own divider style šŸ˜

    I see you have fixed your code according to the suggestion of the previous comment, but you forget to Generate a new report. Please update them šŸ› 

    I hope this helps. Keep it up your good work šŸ”„šŸ’„

    Happy Coding ā˜•

    0
    Icekid35ā€¢260
    @Icekid35Posted over 2 years ago

    @msuryaditriputraR thanks alot for the tip

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord