Responsive Page Using Flexbox

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  Hiyo,

  You did pretty good on this one, there's on a few things I'd like to suggest:

  1. Your aim would be to make this design work on all screen sizes, larger than 1540px included (especially considering how many people are using screens a lot wider than that). You could center the content and make the top bg image cover the whole width of the screen.

  2. It's great that you thought of writing alt text but I'd suggest revisiting them after reading this article.

  3. I'm not sure why your headings have hover states? It's not necessarily bad, if that's the way you like it but users might mistake these for clickable links.

  4. Footer nav: ul can only have lis as their direct children. You can't group your lis in a div, ul is there exactly for that! In this case it would be better to have multiple ul elements for styling the footer nav the way you wanted.

  5. The company logos in the companies section also have hover states which again, may mislead users that these are actual links. If you like this design, maybe you could actually wrap the images in a tags?

  I'd say the rest is good, you even thought of adding aria-labels. All in all, great job!

  2

  ---

  

  Nightcode16•110

  @Nightcode16Posted almost 3 years ago

  @FluffyKas thank you ❤ I appreciate it, I' ll implement your suggestion on the next challenge. Thanks bro🖤

  0
• 

  Dev Rathore•2,600

  @GitHub-dev12345Posted almost 3 years ago

  Give the footer background color is :- background : whitesmoke;

  and Good Work, Keep it up

  I hope you find this helpful 👍

  1

  ---

  

  Nightcode16•110

  @Nightcode16Posted almost 3 years ago

  @GitHub-dev12345 ohh i forgot to put it 😁 , thanks men but lets just keep it that way for now I'll be careful to the footer background next time. Thanks I appreciate it 🖤

  0