Design comparison
Solution retrospective
Please give me feedback on my solution!
Community feedback
- @SuleeymanPosted over 3 years ago
The layout is well done, except your image between
[900px - 800px]
. To remain for this issue, you can simply add aheight: 100%
on yourimg__container
. Then addheight: 100%
on your images and,object-fit: cover;
Also, you should add a
padding-top and -bottom on your flex__container--content.
Moreover, you don't need a neested<div>
on yourflex__container--content.
And for finish, in SCSS, variables are declared like:$my-variable: value;
And you don't need to nest them in your:root
element.In SCSS we can nest our CSS style like:
header { h1 { } }
Which means in CSS:header h1 { }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord