@Islandstone89
Posted
HTML:
-
Every webpage needs a
<main>that wraps all of the content, except for<header>andfooter>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change the first<div>into a<main>, and removerole="main", as the<main>element has that role by default. -
I would change the heading to a
<h2>- a page should only have one<h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.
CSS:
-
It is best practice to write CSS in a separate file, often called
style.css. Create one in the same folder as theindex.html, and link to it in the<head>:<link rel="stylesheet" href="style.css">. -
Including a CSS Reset at the top is good practice.
-
Move
font-familyfrom*tobody. -
I recommend adding
1remofpaddingon thebody, to ensure the card doesn't touch the edges on small screens. -
Remove the
widthinpxon the card. We rarely want to give a component a fixed size, as we want it to grow and shrink according to the screen size. -
We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a
max-widthof around20rem. -
font-sizemust never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Paragraphs have a default value of
font-weight: 400, so there is no need to declare it. -
Since all of the text should be centered, you only need to set
text-align: centeron the body, and remove it elsewhere. The children will inherit the value. -
On the image, add
display: blockand changewidthtomax-width: 100%- the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container.max-width: 100%makes the image shrink to fit inside its container.
