Design comparison
Solution retrospective
Tried to make this site look exactly the design. Used Flex. Suggest on the responsiveness of the page or other areas of improvement.
Community feedback
- @rfilenkoPosted over 4 years ago
Hi, would suggest to add button hover states and make box-shadows a little more settled. Otherwise nice implementation 😉
Regards, Roman
1@kpcprasadPosted over 4 years ago@rfilenko Thank you Roman. I'll try not to forget detailing of objects next time.
0 - @shashiloPosted over 4 years ago
I'm a bit confused with your implementation. It doesn't match the designs that were provided. The sectioned box-shadows, button styling, footer structure, etc.
0@kpcprasadPosted over 4 years ago@shashilo Thanks for your feedback. Could you please tell the implementations which you felt confused so that I can improve in those areas. And yes, buttons could be improved a bit. I was more concentrated on the structure and positioning of cards in the page. I could see the design and the solution are almost on same line with some differences in image sizes and fonts. I could have done better if I had sketch files
0@shashiloPosted over 4 years ago@kpcprasad If you look at the design compared to your implementation, it doesn't use box-shadows for sections. It's completely different from the design. It has the elements, yes, but it doesn't match the design. In our industry, when a designer gives you their design, sketch file or not, you need to match it as closely to the design as possibly. I understand it's difficult if you don't have the art file(s), but this implementation looks like almost a different design because it doesn't match many of the elements in the design. I hope this makes sense.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord