Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted over 1 year ago
Hey there! 👋 Here are some suggestions to help improve your code:
- ⚠️ The logo, intro heading and paragraph should all be wrapped inside a
header
element.
- The logo is not not decorative, Its
alt tag
should not be blank. The description should state the company’s name.
- You want to programmatically link ⚠️ the
input
and error message by adding aaria-describedby
to theinput
.
More Info:📚
- Instead of using
input type="submit"
use thebutton
element as the method you are using is outdated ⚠️.
- The social media icons need to be interactive and direct users to the company's social media accounts so they need to be wrapped ⚠️ in an
anchor
element. The social media icons should have aaria-label
to improve accessibility.
- The social media icons should also be built using an
unordered list
element.
- Your
EventListener
⚠️ should be on theform
and it should be asubmit
not aclick
, since the user is submitting their email.
More Info:📚
Click vs. Submit EventListeners
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 👾
Marked as helpful0 - ⚠️ The logo, intro heading and paragraph should all be wrapped inside a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord