Responsive page using CSS grid

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey!

  • Using more than one <h1> is allowed by the HTML specification, but is not considered a best practice. Using only one <h1> is beneficial for screenreader users.

  ---> Multiple <h1> elements on one page

  Hope this help!... Keep coding👍

  Marked as helpful

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Siddhi, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • Tip of graphic design: with font-family:" Big Shoulders Display ", cursive the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with a font-family:" Big Shoulders Display ", sans-serif much more similar to the primary font.
  • add main tag and wrap the card for improve the Accessibility
  • to make it look as close to the design as possible add hover state with border to button element
  • use min-height: 100vh to body instead of height

  Hope this help! Happy coding 😁

  Marked as helpful

  1

  ---

  

  Siddhi•90

  @siddhiePosted over 2 years ago

  Hi, Deniel Den

  Thank you for your valueable feedback. I've made changes after reading your feedback and updated my project.

  Please check it and let me know if any changes need to be made to the project.

  Regards, Siddhi Nandaniya

  1