Responsive page using css grid

Community feedback

• 

  Peter Jacobs•190

  @thisispeterjPosted 8 months ago

  The layout of the grid looks good, matching the overall feel of the design. The size of the columns is a little tall however, and should be more tightly centered to the page per the design. The HTML could benefit from more semantic elements being used, there is a nice article on W3 Schools highlighting these. https://www.w3schools.com/html/html5_semantic_elements.asp

  The CSS classes should be a little more descriptive, it's difficult to follow what each class is doing with names like a1, az2 etc. This would make it easier for a team collaborating on a project to understand your code, and what they should expect it to do.

  The borders on the image profile pictures do match the design. There should only be two of the images with a purple/violet border. There should also be box-shadows on the card. On the first card there should also be a background image of quote, which is an SVG provided in the starter files.

  Overall the look feel of the challenge is good. With a few adjustments to match the design more closely, and some updates to the markup to improve it's readability and reusability.

  Marked as helpful

  0

  ---

  

  SIRSAMUEL014•100

  @SIRSAMUEL014Posted 8 months ago

  Thank you @thisispeterj

  0