Design comparison
Solution retrospective
Hope you can give me some advices about the way I used CSS Grid! Thank you.
Community feedback
- @buneeIsSloPosted over 2 years ago
Hey! @dannxvc, looks like you've pasted the wrong link to your repo, be sure to fix it.
As far as your solution is concerned, it looks great and responds very well so good job!
Adding the
alt
attributes to your images should solve most of the accessibility issues. Hope this helps :)Marked as helpful1@dannxvcPosted over 2 years ago@buneeIsSlo ohh thank you so much! Right, accessibility is key. Please let me know if you can see my repository now, whenever you can, thank you! :)
1@buneeIsSloPosted over 2 years ago@dannxvc Hi again, I took look at your code and it's quite clean and well maintained however, your markup can be made more semantic. For instance, the quotes on each card would be more appropriate inside a
<blockquote>
rather than the good ole<div>
. You can learn more about it hereApart from that everything looks great, keep it up!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord