Responsive page using css grid

Community feedback

• 

  Yazdun•1,310

  @YazdunPosted about 3 years ago

  Hello Vishal 👋 I have one thing to add to argel's great feedback !

  instead of using p tag for your headings, use h1 to fix your ACCESSIBILITY issue

  Marked as helpful

  0

  ---

  

  Vishal Kumar•210

  @LahsivK4070Posted about 3 years ago

  @Yazdun I will take care about that. Thanks

  0
• 

  argel omnes•1,800

  @argelomnesPosted about 3 years ago

  Hey Vishal,

  Nice work with the layout. For the "missing somewhere", that's probably:

  1. font-sizes
  2. 4th card should be labeled as 'Calculator'
  3. horizontal spacing of the cards is too wide

  Bonus: since you're using Grid, you can remove card-2 and card-3 from their container and position each where they should be.

  Marked as helpful

  0

  ---

  

  Vishal Kumar•210

  @LahsivK4070Posted about 3 years ago

  @argelomnes Thanks for your help I missed a lot and didn't even realized it.

  0