Design comparison
Solution retrospective
Hi! I made this using flexbox. Any feedback with respect to the code would be appreciated!
Thank you
Community feedback
- @anoshaahmedPosted almost 3 years ago
To avoid accessibility issues in the future start your headings with
<h1>
and move up by one level each timeGood job! :)
Marked as helpful0@nehanandi09Posted almost 3 years ago@anoshaahmed Hi! thanks for the feedback. I will look into it!
1 - @skyv26Posted almost 3 years ago
Hi! Neha, To solve accessibility issues:
-
You need to use p tag instead of h3.
-
As I can see that you have wrapped img tag inside h3 and it is bad practice and you can see its a semantic issue too.
-
Your image hover state is missing, please add that functionality too. Do as per requirement (suggestion)
Happy Coding ;)
Marked as helpful0@nehanandi09Posted almost 3 years ago@skyv26 Hi, thank you for the feedback! I was having trouble with the hover state. I'll try to implement it. :)
1 -
- @anoshaahmedPosted almost 3 years ago
To avoid accessibility issues in the future, start your headings with
<h1>
and move up by one level each timeGood job! :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord