Design comparison
Solution retrospective
Hello guys, My name is Kishan I'm new to the frontend development I have tried my best to do this project, I would request you guys to take your time and review my solution and please do give a feedback about what could be improved so that i can improve mself. Thank you.
Community feedback
- @shashreesamuelPosted over 2 years ago
Hey good job completing this challenge
Keep up the good work
Your solution looks great however I think that the font family of the solution should match the one specified in the
style-guide.md
fileI hope this helps
Cheers Happy coding 👍
Marked as helpful0@Kish-hanPosted over 2 years ago@TheCoderGuru TQ mate I will make sure to match the style-guide.md in my future projects. Thankyou for your feedback
0 - @sparrowslPosted over 2 years ago
Hi Kishan, nice work really, few points:
- use the font provided in the style-guide file
- also try to use labels for each form input
eg: <label for="email"> <input type="email" id="email"> </label>
Good job
Marked as helpful0@Kish-hanPosted over 2 years ago@benjithorpe Thankyou for your suggestion I will make sure to follow what u have suggested in my upcoming projects
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord