@danielmrz-dev
Posted
Hello @kshr-kumar!
Your solution looks pretty good!
I have a few suggestions:
-
Use tag
img
for the img instead of an empty div andbackground-image
. -
For semantic reasons, and since that is the main title of the screen, you can replace the
<p>
with<h1>
.
The <h1>
to <h6>
tags are used to define HTML headings. <h1>
defines the most important heading. <h6>
defines the least important heading. Only use one <h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>
, then use <h2>
, and so on.
- Also, still about semantic HTML, you can replace your
div.flex-container
withmain.flex-container
.
All these changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful