Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
Unless if your company requires you to use a library , I strongly suggest you stay away from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library, you are robbing yourself from actually learning how to code.
-
There needs to be a
header
andmain
element in your HTML code. -
The “Reliable, efficient delivery Powered by Technology” is one single heading so the entire thing should be wrapped in a single
h1
heading along with aSpan
element. -
Along with the blank
Alt Tag
, you also want to include thearia-hidden=“true”
to your “icons” to fully remove them from assistive technology. -
Using CSS Grid with
Grid-Template-Areas
will make things way easier when building the layout; it will give you full control of the layout.
Here is an example of how it works: EXAMPLE
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful1@gdemartino93Posted about 2 years ago@vcarames Hi buddy boss, Im glad to receive your attention and your advice.
- I m using bootstrap to pratices it but im sure i can make this layout without BS
- I ve added header and main element
- I ve added aria-hidden="true" to the icons
About CSS Grid, I'm curious to ask you if isnt similar things as Bootstrap uses their grid layout 12col.
I look forward to your reply, Thanks for all.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord