Submitted about 1 year ago

Responsive page solution using Tailwind CSS

Bhawna Pandit• 80

@bhawnapandit26

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

My approach was to first make the body of full screen (using vh) and then add a card to it in the center both horizontally and vertically (using grid). After that I simply added the contents. Is there any better approach to this?

Community feedback

Atif Iqbal• 3,200

@atif-dev

Posted about 1 year ago

Hi, congrats🎉 on completing the challenge. Better take care about following points.

You must be seeing some accessibility issues. To avoid accessibility issue "All page content should be contained by landmarks" use code as :

<body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.

Hope you will find this Feedback Helpful.

Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn

Marked as helpful

Bhawna Pandit• 80

@bhawnapandit26

Posted about 1 year ago

@atif-dev Thankyou for your time to review code and I will make sure to keep these points in mind :)

Kanishka Priyashantha• 690

@kanishkasubash

Posted about 1 year ago

Hi, Bhawna👋. Congratulations on successfully completing the challenge! 🎉

Your solution looks great, and you've done a fantastic job overall! However, here are some small suggestions that might interest you:

It's important to note that the alt text should be descriptive but concise, conveying the essential information without being overly long. It should provide a meaningful summary of the image's content and purpose. (Eg: alt="QR Code for frontendmentor.io")
Starting with <h1> and working your way down the heading levels <h2>, <h3> etc. helps ensure that your document has a clear and consistent hierarchy. Source

I hope you find this helpful! 😄 Keep up the great work! 👍

🖥️Happy coding!

Marked as helpful

Bhawna Pandit• 80

@bhawnapandit26

Posted about 1 year ago

@kanishkasubash Thankyou sir , it is helpful. I will be keeping in mind for these points and will be implementing it

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord