Design comparison
Solution retrospective
My code is not perfect, you can criticize! and can also praise, thank you.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @jorgealves-b, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
1.Add transitions to make the interaction smoother while the element gets hovered, you can use a value like
transition: all ease-in 0.5s
.2.
IMPROVE YOUR WORKFLOW
using VSCODE you can code your whole page usingpx
and then in the end use a plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem ✌️ I hope this helps you and happy coding!Marked as helpful0 - @VCaramesPosted about 2 years ago
Hey @jorgealves-b, great job on this project!
Some suggestions to improve you code:
- For the "Why Us" section, I notice that your using <br> to create the list. A more efficient way would be creating an **unordered list <ul> to create list.
Syntax:
<ul> <li></li> <li></li> <li></li> <li></li> <li></li> <li></li> </ul>
Source:
https://www.w3schools.com/html/html_lists_unordered.asp
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul
- To help keep your CSS code organized and easier to use, I suggest implementing CSS Variables. This will come in handy when building large websites, using light/dark mode, etc…
It’ll look something like this:
:root { --primary-color: value; --secondary-color: value; --tertiary-color: value; }
And to use the variables you’ll use the var() function. So it’ll look like this.
h1 { color: var(—primary-color); }
Heres are some articles regarding CSS Variables.
You can also take a look at my projects and see how I use it.
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties
https://www.w3schools.com/css/css3_variables.asp
Happy Coding!
Marked as helpful0 - @jorgealves-bPosted about 2 years ago
ooooh, nice ! I didn't know about this converter. thanks
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord