Responsive page made with using CSS grid and vanilla Javascript

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Nice work, Gurkiran! Here are some pointers after taking a look at your code:

  • You've got a h1 on the page that you've hidden and then you've got the alt text of "logo" on the logo. If you want the company name to be the h1 here, I'd just add the company name as the alt text and wrap the h1 around it.
  • For the h2 text, you've uppercased the content in the HTML itself. Try to avoid doing that as some screen reader software will read this content letter-by-letter which makes that content inaccessible to screen reader users. Instead, write it normally in your HTML and then use text-transform: uppercase; in your CSS to visually uppercase the text to match the design.
  • You're using the br tag a lot to space out your content. I'd recommend avoiding this, as you could use padding and margin in your CSS and have much more control with less code.

  I hope this helps. Keep it up! 👍

  1

  ---

  

  Gurkiran Singh•170

  @g4rry420Posted over 4 years ago

  @mattstuddert Thank You for your comment and I try not to make these mistakes in the future.

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  @g4rry420 you’re welcome!

  0