Design comparison
Solution retrospective
This is the 2nd version of this. Should I not use min() and max() as if they are used it is showing HTML validator error
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi karthikeya pvs, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
- Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem
The rest is great!
I hope it helps... 👍
Marked as helpful0 - @Deevyn9Posted about 2 years ago
Hi, congrats on completing this project, your solution looks really good, However you'll need to set the background repeat of the pattern to no repeat. Also, the arrow button is overflowing from the input field.
I hope you are able to solve these problem.
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord