Responsive page GRID/FLEXBOX

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ANCHOR ELEMENT 🔴:

  • The <a> elements lacks aria-describedby attribute which is way more important for social links in an <a> tag can help provide more context to users with visual impairments who use assistive technologies such as screen readers to access your website.

  ---

  • The attribute aria-label is only for input elements, and used as an alternative for label element. But using it for a will serve no purpose.

  ---

  • When a screen reader encounters an anchor tag with a social link, it may announce the link's text content, such as "Facebook" or "Twitter," by including an aria-describedby attribute that points to a nearby element containing a description of the link's purpose, you can provide more context and clarity to the user.

  ---

  • By providing this additional information, you can help users with visual impairments to better understand the purpose and value of social links, and encourage them to engage with your content. This can ultimately improve the user experience on your website, and make it more accessible and inclusive for all users.

  ---

  • Example:

  <a class="footer__link" href="#" aria-label="Facebook profile of Huddle">
     <i class="footer__icon fa-brands fa-facebook fa-2xl"></i>
  </a>
  

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Great job 👍, but I have some recommendation!

  • Replace max-width: 70rem in the main to the max-width: 82.5rem, like this it's going to look better on larger screens.

  0