Design comparison
Solution retrospective
- formatting the card content was tricky to do
- I'm unsure of the background. the background patter given doesnt look like the same as he one on the design
- Does my code violate best practices
Community feedback
- @HassiaiPosted over 1 year ago
Replace <section class="container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
Give the body a background-color pale-blue and give the body a background-size of contain instead of object-fit.
To center .card on the page using flexbox, replace the height in .container with min-height: 100vh.
For a responsive content, replace the width in .card with max-width and increase its value for it to be equivalent to the design.
max-width 432px
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord