Responsive page achieved with css flexbox

Community feedback

• 

  amrajat•170

  @amrajatPosted over 1 year ago

  Congratulations on completing the challenge.

  I want to suggest the below points please consider if you feel helpful.

  • Why did you wrap this component within content-wrapper I feel it does just unnecessary nesting.
  • This component is not centered horizontally and vertically if can fix this easily with easy hacks such as margins, using Flexbox or grids.
  • You did not choose the right breakpoint for the media query. always choose the breakpoint where the design starts breaking.
  • max-width: 50% on .content is not a good value here. try something more meaningful here you could have used rems for ease instead of screen-based units %s.
  • the box shadow seems a little dark here which is not looking realistic please consider reduced $alpha

  You can see my solution for the same challenge.

  https://www.frontendmentor.io/solutions/results-summary-component-html-css-sass-obzWVuf4OG

  Happy coding :)

  1

  ---

  

  Eze Samuel•20

  @Eyepop01Posted over 1 year ago

  @amrajat thank you so very much for taking your time to point point out this correction... I appreciate... I'll work on it...

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! 🎉.That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add hover effect on button as per design. Here's an example code snippet:

  .summary button:hover
  {
  background: linear-gradient( 252, 100%, 67%,  241, 81%, 54%);
  }
  

  1

  ---

  

  Eze Samuel•20

  @Eyepop01Posted over 1 year ago

  @Kamlesh0007 thanks a lot... ❤️❤️❤️

  0