
Design comparison
Community feedback
- P@xuaunPosted about 1 month ago
Hello Mateus,
Congratulations on your work on this project! I believe you did very well. I hope my comments help you evolve in your future projects.
Main difference
The main point that caught my attention was the lack of
padding
orpadding-top
in yourbody
.Code semantics
I saw that you included all the texts in your code as
h1
-h5
, I believe that this is not the best choice for the semantics of your code. One suggestion would be to leave your entire title ash1
(and not parth1
and parth2
) and the titles of the cards ash2
and everything else asp
. In the main title you could have used another semantic tag to differentiate the texts, such as<span>
,<b>
or<strong>
.Other comments
Other things I noticed were:
- Shadow color slightly different from original design
- Main title smaller than in original design
- Some card size smaller than in original design
- Spacing/margin between
<header>
text and cards smaller than in original design - Top collored border of cards larger and more curved than in original design.
Keep it up and you will go far in your future projects!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord