@jakegodsall
Posted
Hi π
Great work on this component.
Layout wise, the major think I can see here is that you could have done with a little more padding on the left and right of your text-component element. The musical note and the change link seem to be a little close to the edge.
I really like how responsive this design is, especially how the height of the component shrinks with decreasing viewport, but there is a point where the shrunk component snaps back to full size at 540px viewport height. The components snaps from around 450px in height to approximately 530px. Not a huge issue, I really had to search to find something to criticise here! π
Hope this helps
Marked as helpful
@rohitd99
Posted
@jakegodsall Thank you for your suggestions, actually I knowingly kept it so because while making it responsive I viewed it on the Iphone 4 from developer tools and the height was too small for the components so I did the height to auto.
But I can fix it by adding a margin:20px;
to the article. But I do not know how to make the transition smooth and not make it snap back.