Design comparison
Solution retrospective
First project done without following a tutorial. I think the result is pretty good but would love to hear some inputs. I have the feeling my code could be simplified by using better css properties. Would love to hear any feedback so I can do better next time!
Community feedback
- @martinelias1312Posted about 3 years ago
Hello Mitch,
here are my few suggestions: When you use article or section element, they should have heading like <h2>.
For easier responsive design you can use relative lenght units instead of px. (it can heavily shorter your code in Media queries) https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Values_and_units
Shorter code in css E.g.:
background: url(images/pattern-background-mobile.svg) no-repeat; (2 settings in one row)Last thing that i perosnally use is https://validator.w3.org/ for validating your code.
But anyways, pretty nice flexbox usage and code.
Good luck on your next challenges!
Marked as helpful1@mitch-webdevPosted about 3 years ago@smradupan Hey Martin,
Thank you so much for taking the time to give me suggestions. Really appreciate it!
I will definitely make those changes and have a read at the articles your recommended.
Cheers,
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord