Responsive order summary page using FlexBox

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @chriszych!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Use <h1> for the main title instead of <h2>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0

  ---

  

  chriszych•50

  @chriszychPosted 9 months ago

  Thanks @danielmrz-dev for your valueble feedaback

  1
• 

  Noel Hoppe•350

  @noelhoppePosted 9 months ago

  Hi, some suggestions:

  1. Remove body { margin: 25px; } and replace it with body { min-height: 100vh; }
  2. It's good practice to use a normalize.css file to reset browser's default behaviour. For example install with npm install normalize.css in Terminal and than link normalize.css to your *index.html file
  3. Remove main { margin-top: 75px; }
  4. Instead of using div's try to use HTML semantic elements such as main, element, article, section
  5. <h2>should be <h1>because it's the only heading.
  6. "Anual Plan" should be a <p>
  7. Remove marginfrom div.paymentand set gap: 20pxto div.plan
  8. "$59.99/year" should be in a `<p>``
  9. Remove div.space and give the `div.payment { margin: 0 auto 0 0; }
  10. Remove margin from div.orderand div.plan
  11. "Proceed to payment" is a <button>
  12. "Cancel" is a <button>
  13. Remove div containers from "Proceed to payment" and "Cancel" and replace it wiht button and style it with css. Happy Coding

  Marked as helpful

  0

  ---

  

  chriszych•50

  @chriszychPosted 9 months ago

  Wow, thanks a lot @noelhoppe, now I know what to correct.

  0