Design comparison
Solution retrospective
What are the things that I can improve?
Community feedback
- @MelvinAguilarPosted over 1 year ago
Hello there ๐. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
- For specificity reasons you should work with classes instead of ids because they are more reusable. You can use ids to work with JavaScript, but you should use classes to style your elements. You can read more about this here ๐.
- You should use the
cursor: pointer
property to indicate that the element like a button or a link is clickable.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1@Aditya-768Posted over 1 year ago@MelvinAguilar Thanks for giving your valuable suggestions. I will definitely improve next time. I forgot to give cursor pointer.
0 - @HassiaiPosted over 1 year ago
Replace <h4> with <h2> to fix the accessibility issues.
You forgot to give the body a background-image with a background-size of contain and background-repeat of no-repeat. The background-image can be found in the images folder in the zip folder you downloaded.
Give the main a fixed max-width value
max-width: 27rem which is 432px
.Give the button a box-shadow with a color hsla(245, 75%, 52%, 0.4).
This challenge requires a media query, in the media query you only have to change the background-image of the body.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1@Aditya-768Posted over 1 year ago@Hassiai Thanks for feedback. I will improve it. Actually many times I don't understand the style.md file especially where to use which color.
0@HassiaiPosted over 1 year ago@Aditya-768 before the starting project you use the sample html a design it withe colors then you will know which color is for wat before starting the challenge. some colors may be very obvious use this for the difficult ones.
Marked as helpful1 - @Finney06Posted over 1 year ago
Hello there ๐. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML ๐ท๏ธ:
To clear the Accessibility report:
- Always avoid skipping heading levels; Starting with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that your document has a clear and consistent hierarchy.
I hope you find it helpful!๐ Above all, the solution you submitted is ๐. ๐Happy coding!
Marked as helpful1@Aditya-768Posted over 1 year ago@Finney06 Thanks for helping. I didn't know about this.
0 - Always avoid skipping heading levels; Starting with
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord