Design comparison
SolutionDesign
Solution retrospective
Any advice/criticism is welcome!
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @CaseyLawver!
You did a very good job there!
I have just one very simple suggestion for improvement:
- Since the button is a clickable element, it's nice to add
cursor: pointer
to it. It gives the user one more visual indication that the element is clickable.
I hope it helps!
Other than that, you did a great job!
0 - Since the button is a clickable element, it's nice to add
- @AGutierrezRPosted 11 months ago
Hello there @CaseyLawver 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
CSS and Styling:
- Implement CSS custom properties to define and utilize project colors more easily.
- The
body
should not have itsheight
limited. Instead of usingheight: 100vh
, usemin-height: 100vh
.
Accessibility and Semantic HTML:
- The icons/illustration images are decorative, so their alt text must be empty:
alt=""
.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord