Design comparison
Solution retrospective
please give a feedback how to inprove and get rid of unnecessary code.
Community feedback
- @HassiaiPosted over 1 year ago
<maim> should be the main tad <main> to fix the accessibility issues. click here for more on web-accessibility and semantic html
There is no need for double declaration of the background-size in the body, give the background-size a value of contain. give the body a background-color of pale-blue.
To center .card on the page using grid only instead of grid and margin, replace the height in the body with min-height: 100vh and add justify-items: center to the body
For a responsive content , give .card a fixed max-width value.
max-width: 432px which is 27rem/em
Use relative units like rem or em as unit for the padding, margin and width values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord