@MelvinAguilar
Posted
Hi @dvd41esp 👋, good job for completing this challengey! 🎉
Here are some suggestions to improve your code:
-
Use
min-height: 100vh
tobody
selector instead ofheight: 100%
, with this property you set a height and you let the element grow even more if necessary. -
The music icon is for decoration purposes only, so it could be hidden from screen readers by adding
aria-hidden="true "
and leaving its alt attribute empty:
<img src="./images/icon-music.svg" class="musicIcon" alt aria-hidden="true">
- The
form
tag is used so that the user can send information, in this challenge theanchor
tag is enough
I hope those tips will help you.
Good Job and happy coding !
Marked as helpful
@dvd41esp
Posted
@MelvinAguilar Quite helpful actually. Didn't remember how to use the vh unit. Thanks!