matthewohreluy• 95
@matthewohreluy
Posted
Yours looks really clean. It's perfect.
Marked as helpful
0
Ahmed Faisal• 5,095
@afrussel
Posted
@matthewohreluy Thanks
0
Feedback required
@matthewohreluy
Posted
Yours looks really clean. It's perfect.
Marked as helpful
@afrussel
Posted
@matthewohreluy Thanks
@pikapikamart
Posted
Hey, great work on this one. Layout in desktop and mobile seems fine. The desktop I think is too big.
Some suggestions would be:
height: 100vh
. This will limit the height
of the element and it will be fixed to 100% of the viewport's height. If you inspect your website in dev tools at the bottom, you will noticed that it can be scrolled. Instead, replace it with min-height: 100vh
, it will take 100% of the viewport's height and it will expand if it needs to. You don't need to have the overflow: hidden
, this will just cut the website which is not really good.main
element. This will make it more structured and help user to navigate in your website.alt
value of the music-icon should be left empty like alt=""
since it is not really adding to the content. If the img
adds value to the website, add a descriptive alt
if it is just decorative like this one, leave it alt=""
.alt
text. Assistive tech will handle those for you.change
dimension, try using tab
key in your keyboard, you will notice that it takes a large portion compared to its content. You might want to check that one out.padding
to the top and bottom of the body
tag, just to prevent the layout from touching the ceiling and flooring of the screen.Aside from those, great work.
@uiGuys
Posted
Great work, so nice. Keep it up
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord