Submitted over 1 year ago
Responsive Order Summary Component Using Flexbox
@abanoub-refaat
Design comparison
SolutionDesign
Solution retrospective
Hello again guys,
I've just completed this challenge and I would love to read your feedback on it please.
Thanks for your time!
Community feedback
- @adityaphasuPosted over 1 year ago
Hi!
Nice solution!
Some points to improve your code and design:
- Try removing
background-size: cover;
from the body so that the background image doesn't cover the whole page. - when setting font size try using relative units like
rem
instead of using absolute units likepx
as they are better for scalable layouts. You can read more about it here! - Instead of using a
div
as a container you should use the <main> tag which is generally good for accessibility purposes, it provides a clear and meaningful structure to your HTML and it helps search engines understand the purpose and the main content of the page.You can do it like this:
<main class="container"> //rest of the code </main>
Overall good work!
Keep up the hard work and good luck!😊
Marked as helpful1 - Try removing
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord