Design comparison
Solution retrospective
Is my responsive good ? I don't know if i use the correct method to do the responsive part
Community feedback
- @correlucasPosted about 2 years ago
πΎHello Roms, congratulations for your new solution!
To fix the issue with the responsivity you need to replace the
width
withmax-width
. Note that the difference between these two properties is thatwidth
is fixed, example,width: 340px
is an container that doesn't get bigger or smaller than340px
butmax-width: 340px
have the maximum of340px
and can contract when the screen scales down and adjust its size.Here's the fixes for you image background and the color to make it full height/width using
background-size: contain;
:body { background-image: url(./images/pattern-background-desktop.svg); background-repeat: no-repeat; height: 100vh; background-color: #e8edf9; }
π¨βπ» Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/order-summary-component-vanilla-css-custom-wave-background-hover-tEKUwaT2id
π I hope this helps you and happy coding!
Marked as helpful0 - @Har1s-AkbarPosted about 2 years ago
You have done a great job. There are somethings wrong with the mobile version, I think you are using height to the screen because it is not scrollable on mobile version and also the background is not covering the whole width of screen on desktop version. You should fix these issues. All in all you did a great job, keep coding
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord