Responsive Order Summary Component Using flex

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 2 years ago

  It's very important you do not change visible label text to something else with aria-label! That makes this inaccessible

  Looking at the html

  • you need to look up how and when to write alt text and how to treat decorative images
  • can you explain why you've chosen the elements you have for change proceed and cancel? What would you expect to happen on click of each one?
  • text must never be in divs or spans alone. Always use meaningful elements

  Css looks good except you should definitely be working mobile first, not desktop first

  0

  ---

  

  Muhammadh•1,140

  @Mr-jawPosted almost 2 years ago

  @grace-snow

  • Yes, I should have used <a> for both 'proceed to payment' and 'cancel order'. because when I click the 'proceed to payment button I would expect it to redirect to a payment gateway and when I click the 'cancel order' button I would expect it to go to the home page or something like that

  • And, I didn't understand what are you trying to say from the third point. Since I don't have text alone in divs or spans

  Thanks for pointing out 😊

  0