Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi G-nm, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - remove all
margin
fromcontainer
class - try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container
Overall you did well :)
Hope this help and happy coding!
1@gmwanikiPosted over 2 years ago@denielden thanks for the feedback. I've removed the unnecessary code and made changes to the margin on the container class and am using flexbox to center it on the viewport Thanks again and happy coding
1 - remove all unnecessary code, the less you write the better as well as being clearer: for example the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord