Design comparison
SolutionDesign
Solution retrospective
Hi! Please give me some feedback on my code. Especially when it comes to making the design responsive.
Community feedback
- @vanzasetiaPosted about 3 years ago
👋Hi Carlton!
👍 Good job on completing your first challenge! Some feedback from me:
- The illustration hero image is stretched.
- For any decorative images, like in this case the hero illustration and the music icon, you should leave the
alt=""
empty and addaria-hidden="true"
orrole="presentation"
to make sure all screen readers ignore those images. - The
Annual Plan
should not be a heading. Heading tag is commonly used for titling asection
orarticle
. Usestrong
tag instead. - You don't need to specify, the height of the
html
element. - Use
rem
or sometimesem
instead ofpx
. Usingpx
unit will not allow the user to control the size of your page.
That's it! Hopefully this is helpful!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord