Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Order Summary Component

Carlton 130

@CarltonMpofu

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! Please give me some feedback on my code. Especially when it comes to making the design responsive.

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

👋Hi Carlton!

👍 Good job on completing your first challenge! Some feedback from me:

  • The illustration hero image is stretched.
  • For any decorative images, like in this case the hero illustration and the music icon, you should leave the alt="" empty and add aria-hidden="true" or role="presentation" to make sure all screen readers ignore those images.
  • The Annual Plan should not be a heading. Heading tag is commonly used for titling a section or article. Use strong tag instead.
  • You don't need to specify, the height of the html element.
  • Use rem or sometimes em instead of px. Using px unit will not allow the user to control the size of your page.

That's it! Hopefully this is helpful!

1

Carlton 130

@CarltonMpofu

Posted

@vanzasetia Thanks for the feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord