Design comparison
Solution retrospective
Any feedback is welcome ! For text like "Annual Plan", "$59.99/year", "Change" or "Cancel Order", should they be paragraphs or spans ? I'm wondering about accessibility best practices.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BACKGROUND iMAGE 📸:
- Looks like the
background svg
andcolor
has not been set properly, let me explain How you can easily apply thebackground color
with thesvg
they provided.
- Add the following style rule to your css, and then experience the changes
body { background: url(./images/pattern-background-desktop.svg), #E1E9Ff; background-repeat: no-repeat, no-repeat; }
- Tip, Don't forget to generate a new screenshot after editing the
css
file
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @BernardusPHPosted over 1 year ago
hello FUNKYCREEP
For the ( "Annual Plan", "$59.99/year", "Change" or "Cancel Order",) part I believe a
div
for the container and then as children animg
for the music image then anotherdiv
as a container for the "Annual Plan", "$59.99/year" part.The Annual Plan can be a lower header(h2,h3,h4 etc.) and the "$59.99/year" can be a "span". The Cancel Order should an
a
since its a link but if you have trouble with responsiveness then wrap the anchor in a div of its own.I believe this should be right but if anybody has any better idea then I will listen.
Hope this helped.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord