@denielden
Posted
Hi Rina, great work on this challenge! 😉
Here are a few tips for improve your code:
- for add the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;
- centering with
absolute
positioning is now deprecated, it uses modern css likeflexbox or grid
- remove all
margin
from.container
class because with flex they are superfluous - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
Marked as helpful
@dodrin
Posted
@denielden thank you for your feedback. I totally forgot about the background img haha your feedback would helm me improving! cheers happy coding