Responsive Order Summary Component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="container"> with the main tag, <h4> with <h2> and <h5> with <a> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  The body has a wrong background-color its background-color should be pale-blue.

  For a responsive content, replace the width in .container with max-width and increase its value for it to be equivalent to the design. max-width:432px There is no need for a height value in .container rather give .text a padding value for all the sides , this will prevent the content from over flowing.

  Give .payment a margin-top and bottom value instead of position: absolute and its properties. Give . payment a a box-shadow value and .payment a :hover opacity of 5.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Use the font-family that was given in the styleguide.md.

  Give the body a background-size of contain, a background-repeat of no-repeat. In the media query you have to change the background-image of the body.

  To center .container on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  USING FLEXBOX:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  USING GRID:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0