Responsive Order Summary Component Challenge using SCSS

Community feedback

• 

  darryncodes•6,390

  @darryncodesPosted about 3 years ago

  Hi Brian,

  Great solution, really well done!

  • you could tidy up your accessibility report with a few quick fixes. Change <section> to <main> and remove the id=main. Your .attribution <div> should be a <footer> tag.
  • here is a useful guide

  All the best 🤙

  Marked as helpful

  0

  ---

  

  Brian Carlo Birondo•320

  @Briancarlo24Posted about 3 years ago

  @darryncodes

  Your right about the attribution gonna update it soon.

  Thanks for pointing that out.

  0
• 

  Nguyen Duy•245

  @koalalikecodePosted about 3 years ago

  I think you should add the hover state of this site

  Marked as helpful

  0

  ---

  

  Brian Carlo Birondo•320

  @Briancarlo24Posted about 3 years ago

  @koalalikecode Ohh you're right. I totally forgot about that. Thanks for your comment!

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted about 3 years ago

  On your body tag you should change your background size from contain to 100vw 40vh

  Marked as helpful

  0

  ---

  

  Brian Carlo Birondo•320

  @Briancarlo24Posted about 3 years ago

  @palgramming Thank you for that. I should pay more attention next time to the instructions XD

  0