Design comparison
Solution retrospective
Hi!
This is my first ever project that I did without a tutorial, and I know there are a million ways I could have simplified it. I would love feedback on how I could have positioned elements using less code, and if there is a better way, I could have tackled the responsive web design using Media Queries. Thank you in advance for taking the time to look!
Community feedback
- @idesmarPosted almost 3 years ago
You did great! Putting what you learn from tutorials to solving frontend mentor challenges makes you improve your personal technique and approach on web development.
If you want to shorten your code a bit, you could use shorthands for margin and padding, or using flex-box to center items. Shorthands are great but you don't have to use them everytime. There are cases that shorthands could make your code too complicated and hard to debug. What those cases are... you'll learn on the journey to improving more. :)
Happy coding and happy new year!
Marked as helpful0@yazzybandyhamPosted almost 3 years ago@idesmar Thank you so much for taking the time to give me your feedback! I will experiment with flexbox in the next project.
Happy new year to you too! :)
0 - @anoshaahmedPosted almost 3 years ago
To get rid of the accessibility/HTML issues shown in your Report:
- wrap everything in your body in
<main>OR giverole=""to the direct children of your<body>... Click here to read more - start your headings with
<h1>, and move up by one level each time
Good job! :)
Marked as helpful0@yazzybandyhamPosted almost 3 years ago@anoshaahmed Thank you so much for taking the time to help with the error reports! I appreciate the feedback :)
1 - wrap everything in your body in
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord