Design comparison
Solution retrospective
Hello, this is my first time using multiple @media
queries in a single css document. The main thing that I would love to hear some feedback on is the responsiveness of the webpage and if there are any ways I can improve it.
I would also like to hear feedback on anything else I could potentially improve and I will take any mistake you point out as an opportunity for me to improve.
Community feedback
- @RioCantrePosted almost 3 years ago
Hello there! Good job in this challenge. Viewing the solution, I think you should consider the following as well…
- Import the
attribution
style in CSS file and remove thestyle
tag - Adjust the background image property into
background-repeat: no-repeat;
in thebody, html
rule set - In the media queries, remove
background-image: url(images/pattern-background-mobile.svg);
andbackground-repeat: repeat;
from1200px - 651px
breakpoints. - Add
padding: 0 3rem;
in.text-container
rule set - Add
text-align: center;
in.sub-text
rule set - Adjust the border in
.main
intoborder-radius: 20px;
- The music svg is missing in the part of
<div class="plan">
. Addbackground: var(--bgColor);
,padding: 1rem;
andborder-radius: 10px;
in the CSS file - Add
border-radius: 10px;
and adjust the background intobackground-color: var(--bgButton);
in the main button.btnProceed
rule set - Clean the whitespaces in the code
Above all, Well done! Keep it up and Hope this is helpful!
Marked as helpful1 - Import the
- Account deleted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
I have some feedback on this solution:
- change
background-repeat:repeat to no-repeat
to stop repeating the background image - add to the body
background-size:contain
so it fill the whole screen width - add to sub-text div
text-align: center
so that the text get centered - change the background color of the input to #3829e0 and add border-radius:10px
i hope this is helpfull good job and good luck!
Marked as helpful1 - change
- @optimusprime202Posted almost 3 years ago
Hey @AtanasovCode, You’re really improving.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord