Responsive order summary card
Design comparison
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi Zaid Mohammed Zainudeen, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty
alt=""
and addaria-hidden="true"
attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:
- Add a
background-repeat: repeat-x;
, the image will repeat on the horizontal axis, preventing it from breaking. - Add a
background-size: 100% 50vmin;
, the50vmin
will set its height as the page target, and100%
will make it stretch on the horizontal axis.
Feel free to choose one of the two!
The rest is great!
I hope it helps... 👍
Marked as helpful0@iamzaidmohammedPosted almost 2 years ago@AdrianoEscarabote Ohk thanks for reviewing my solution. I'll make sure to implement it in the code
1 - Add a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord